Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get more descriptive errors from flaky test #440

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Get more descriptive errors from flaky test #440

merged 1 commit into from
Sep 30, 2024

Conversation

christiangnrd
Copy link
Contributor

[only tests]

@maleadt maleadt merged commit f605bcb into main Sep 30, 2024
1 check passed
@maleadt maleadt deleted the troubleshoot branch September 30, 2024 18:46
@maleadt
Copy link
Member

maleadt commented Oct 1, 2024

Even though I'm not opposed to fixes like this, I feel like we need something more principled. All of the GPUArrays tests currently suffer from the same issue:

Error in testset gpuarrays/base:
Test Failed at /Users/tim/Julia/pkg/GPUArrays/test/testsuite/base.jl:274
  Expression: compare((x->begin
            #= /Users/tim/Julia/pkg/GPUArrays/test/testsuite/base.jl:274 =#
            circshift(x, (0, 1))
        end), AT, reshape(Vector(1:16), (4, 4)))

@christiangnrd
Copy link
Contributor Author

Yeah this wasn't actually meant to be merged. However I forgot to edit the description or write any indication as such. It should probably be reverted once #442 is resolved but we might as well keep it for now since it allows our CI to pass instead of failing due to a bug that hasn't been reproduced locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants